peaks.js icon indicating copy to clipboard operation
peaks.js copied to clipboard

Add more configuration options to the overview waveform, make it possible to turn on or off the axes

Open ziggythehamster opened this issue 9 years ago • 4 comments

You can now configure:

  • The highlight rectangle padding (we use this because we make our overview bar smaller)
  • The highlight rectangle opacity
  • The overview axis colors

ziggythehamster avatar Jul 02 '15 17:07 ziggythehamster

This now goes against latest master :)

ziggythehamster avatar Jul 02 '15 17:07 ziggythehamster

@oncletom Any chance of getting this reviewed? :)

ziggythehamster avatar Sep 16 '15 17:09 ziggythehamster

Hey!

Thanks for the proposals, they are valuable options!

The list of options is now very long, and I wonder how effective it is for newcomers and peaks users.

In issue #53, I propose to use the same config objects but to pass them to the views directly in order to control them. Next step would be to use the same objects for both views (zoom and overview) and to affect their layout only via configuration. Peaks responsibility would then be to synchronise/handle/dispatch events to the views/media player.

thom4parisot avatar Sep 17 '15 13:09 thom4parisot

Looking at that API, I'm not sure that it covers the same things. This PR gives you some more knobs to turn to customize the appearance of the waveforms (ideally, all of the constants are configurable, but we haven't needed to change everything). I'm all for abstracting that away, I'm just not entirely sure how. In an ideal world, it's controllable via CSS - but I realize you can't do that because we're talking about a canvas.

ziggythehamster avatar Sep 17 '15 16:09 ziggythehamster