bmx icon indicating copy to clipboard operation
bmx copied to clipboard

libmxf: use cmake vars to set default platform name

Open philipnbbc opened this issue 1 year ago • 1 comments

The platform name is used in the (human readable) MXF Identification::Platform property value. This commit keeps the existing names for known platforms defines to avoid breaking scripts that (wrongly) rely on it. If the platform is not known then the name is provided by CMAKE's CMAKE_SYSTEM_NAME and CMAKE_SYSTEM_PROCESSOR variables.

Fixes #83

philipnbbc avatar Jun 26 '24 13:06 philipnbbc

I might need to take another look at this because I'm guessing this won't work for macOS Universal binaries as the config.h file is created at configure time.

philipnbbc avatar Jun 27 '24 07:06 philipnbbc

I might need to take another look at this because I'm guessing this won't work for macOS Universal binaries as the config.h file is created at configure time.

This PR has been updated and re-written.

philipnbbc avatar Jan 15 '25 15:01 philipnbbc

Thank you, looks good AFAICT

I've tried on a Windows machine and a MacBook and got: libMXF (Win64) and libMXF (Darwin ARM64) which looks as expected I think

thomasheritage avatar Jan 16 '25 14:01 thomasheritage

Thank you, looks good AFAICT

I've tried on a Windows machine and a MacBook and got: libMXF (Win64) and libMXF (Darwin ARM64) which looks as expected I think

Great, thanks for testing.

Darwin is a bit legacy but I kept it to not diverge from the existing naming and to avoid also changing the existing naming in case tools are depending on it in some way.

philipnbbc avatar Jan 16 '25 14:01 philipnbbc