bbc-a11y icon indicating copy to clipboard operation
bbc-a11y copied to clipboard

Incorrect errors about h1

Open votemike opened this issue 2 years ago • 8 comments

Summary

Both the website I'm checking and bbc.co.uk say there are no h1's. But there are. In fact, I think all of these warnings are incorrect for the BBC website. This has been testing on a different Mac in a different location too. Same problem.

Screenshot 2022-03-08 at 15 54 39

Expected Behaviour

bbc-a11y correctly identifies accessibility errors

Current Behaviour

bbc-a11y https://www.bbc.co.uk incorrectly shows several errors.

Possible Solution

Steps to Reproduce (for bugs)

  1. Run bbc-a11y https://www.bbc.co.uk

Context & Motivation

I'm trying to check the website I'm working on using your tool. I noticed the problem as my page does have an H1.

Your Environment

  • Version used: 2.4.2
  • Operating System and version: MacOS - 11.5.2
  • Link to your project:

votemike avatar Mar 08 '22 16:03 votemike

I've just checked using --interactive and the console is complaining about the CSP.

votemike avatar Mar 08 '22 16:03 votemike

Hi Micheal,

Thanks for letting us know. Could you share the output of the console with me and I'll have a go at debugging it tomorrow :)

Cheers,

Jamie + Lion


From: Michael Gwynne @.> Sent: 08 March 2022 16:24 To: bbc/bbc-a11y @.> Cc: Subscribed @.***> Subject: Re: [bbc/bbc-a11y] Incorrect errors about h1 (Issue #343)

I've just checked using --interactive and the console is complaining about the CSP.

— Reply to this email directly, view it on GitHubhttps://github.com/bbc/bbc-a11y/issues/343#issuecomment-1061960479, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEJMJWU4LLALKRBYP4N7MCDU655NDANCNFSM5QGYTVFA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.Message ID: @.***>

JamieKnightBBC avatar Mar 08 '22 16:03 JamieKnightBBC

Screenshot 2022-03-09 at 09 08 31

votemike avatar Mar 09 '22 09:03 votemike

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Aug 12 '23 01:08 github-actions[bot]

@JamieKnightBBC this still seems to be a problem.

votemike avatar Aug 14 '23 10:08 votemike

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Sep 14 '23 01:09 github-actions[bot]

This issue was closed because it has been stalled for 5 days with no activity.

github-actions[bot] avatar Sep 19 '23 01:09 github-actions[bot]

Reopening.

nicholasgriffintn avatar Oct 04 '23 21:10 nicholasgriffintn