Billy Brumley
Billy Brumley
> Makes sense? Not IMO. Throw away tests where the bit length is not a multiple of 8. (Alternatively, peel off bit by bit from the end until it is,...
> It seems very uncommon Even more, "never happens". That's why whoever wrote those KATs you're using didn't think it through very well. Preprocess them, then stick that output in...
> there is possibility that mobile hardwares send 'bit' instead of 'byte' From my personal experience, that possibility does not exist. (At least in practice.) When I see these bit...
@mineo333 after you send the ICLA and you've got a confirmation it's been processed, just close and re-open this PR in the GitHub GUI to trigger the checks again. (buttons...
@ak4153 I would expect a regression test for this. It would be a negative test. Off the top of my head, maybe: Put the pem file [in one of these...
You also need to reference the issue #26467 in your `git` commit message.
@paulidale Instead of a standalone C negative test, would the project prefer integrating [here](https://github.com/openssl/openssl/blob/master/test/recipes/15-test_rsa.t) ? Edit: [this is another option](https://github.com/openssl/openssl/blob/master/test/recipes/91-test_pkey_check.t)
> yes to either of those places. great, yea I think [this is a good place](https://github.com/openssl/openssl/blob/7097d2e00ea9f0119a5e42f13a51487fb1e67aa3/test/recipes/91-test_pkey_check.t#L52)
@Finn2689 I see some [existing documentation of the various options here](https://github.com/openssl/openssl/blob/master/doc/man1/openssl-fipsinstall.pod.in) Below could be wrong, just my 2c. My read of the original issue: I think OP @beldmit is asking...
> Note: a "custom" tag was added to the EVP test suite to support the CXOF customization string in test vectors I like how you aligned `Custom` with the existing...