zenburn-emacs icon indicating copy to clipboard operation
zenburn-emacs copied to clipboard

The title level of org-mode and markdown are not clear

Open yuzumx opened this issue 5 years ago • 6 comments

Hello, and forgive me for my poor English.

I really like your theme, but I found some small problems that bothered me.

In other themes, the org-mode and markdown levels are easy to distinguish. But in your theme, there seems to be no way to distinguish anything other than color. This is very difficult for me with color blindness.

I hope to improve, such as the difference in font size. But I am an elisp rookie, so I can't provide PR for this, sorry.

Thank you.

Some screenshots: 2

1

Leuven Theme: 3

yuzumx avatar Jul 15 '18 06:07 yuzumx

Here is what I use in my modified zenburn: https://github.com/georgek/zenburn-emacs/blob/my-mods/zenburn-theme.el#L1092

I only use a subtle size difference for title and level 1 heading, but I use proportional fonts which makes a big difference visually.

I think this is a very personal thing and zenburn doesn't change font sizes in other places AFAIK. So you might have to maintain your own mod branch like me because I doubt a change like this would get merged (might be wrong, though).

georgek avatar Aug 08 '18 20:08 georgek

thanks for your reply @georgek

If this is the design of zenburn, then I might really need to maintain a version of myself.

I may not close this issue because I feel that my question has not been answered. But if this issue is stupid, please close it.

Thank you.

yuzumx avatar Aug 12 '18 05:08 yuzumx

You are able to just overwrite single faces inside your emacs config, so you wouldn't have to keep the whole version along and can just use upstream.

ksjogo avatar Aug 12 '18 15:08 ksjogo

Yes. I use to do that actually. I just had a separate mods file which I would load after the theme: https://github.com/georgek/dot-emacs/blob/master/themes/zenburn-mods.el

The reason I inlined mine was because I was having strange problems when byte-compiling emacs lisp. For some reason elements of the style outside the one loaded by deftheme get lost. I still haven't figure that one out.

georgek avatar Aug 12 '18 17:08 georgek

For what is worth - I'm fine with adding a configuration option (defcustom) about using dynamic-font-sizes for headings/titles/etc. I generally dislike them as I think the markup itself gives enough info about the heading size and I like uniform fonts in source buffers, but I know many people have different opinion, so I'm fine with adding this if it's something opt-in.

bbatsov avatar Sep 26 '18 06:09 bbatsov

I'll have a go at adding this feature over the weekend then, unless someone else gets to it first.

georgek avatar Sep 26 '18 18:09 georgek