solarized-emacs icon indicating copy to clipboard operation
solarized-emacs copied to clipboard

Missing faces for tab-bar mode

Open exot opened this issue 3 years ago • 0 comments

Hey,

it appears that the solarized-themes are missing faces for tab-bar-mode (not to be confused with tabbar-mode, for which face definitions are already present). Today I found some time to tinker with this and came up with the following snippet for my init.el:

(setq custom--inhibit-theme-enable nil)

(custom-theme-set-faces
    'solarized-dark
    `(tab-bar ((t (:height 1.2
                         :foregreound ,(cdr (assoc 'base03 solarized-dark-color-palette-alist))
                         :background ,(cdr (assoc 'base03 solarized-dark-color-palette-alist))))))
    `(tab-bar-tab ((t (:background ,(cdr (assoc 'base02 solarized-dark-color-palette-alist))
                               :foreground ,(cdr (assoc 'magenta solarized-dark-color-palette-alist))
                               :inverse-video nil
                               :box (:line-width 1 :style released-button)))))
    `(tab-bar-tab-inactive ((t (:inherit tab-bar-tab
                                            :background ,(cdr (assoc 'base0 solarized-dark-color-palette-alist))
                                            :foreground ,(cdr (assoc 'base03 solarized-dark-color-palette-alist))
                                            :inverse-video t
                                            :box nil)))))

(Parts of this have been take from the sanityinc-tomorrow-night theme).

That's quite a crutch I guess, but it seems to work for the time being …

Would it be helpful to have those definitions (when sufficiently adapted) being added to the main solarized-definition variable? In that case, I could prepare a PR, or somebody could just copy that over to solarized-faces.el.

Best,

  Daniel

exot avatar Sep 18 '21 09:09 exot