projectile icon indicating copy to clipboard operation
projectile copied to clipboard

Support OSC-SCM

Open Thaodan opened this issue 1 year ago • 3 comments


Support the OSC SCM as used in the open build service. OSC can be used with vcs-osc in Emacs.

The code is wip but I wanted to post this PR to get some feedback and show progress working on it.

Osc works a little different than other scms where there two different types of repositories, one containing packages and the other being a package. The type that is package works very much like a regular scm where commands such as those to open project files work as a user would expect.

But for the project type the commands referring to files target the packages the project contains.

I've implemented the functionality using the builtin XML functionality as that is the easiest since osc's own files use XML.

I'm not exactly sure how to add test, any help is appreciated.


Before submitting a PR make sure the following things have been done (and denote this by checking the relevant checkboxes):

  • [ ] The commits are consistent with our contribution guidelines
  • [ ] You've added tests (if possible) to cover your change(s)
  • [ ] All tests are passing (eldev test)
  • [ ] The new code is not generating bytecode or M-x checkdoc warnings
  • [ ] You've updated the changelog (if adding/changing user-visible functionality)
  • [ ] You've updated the readme (if adding/changing user-visible functionality)

Thaodan avatar May 09 '24 19:05 Thaodan

I'm not exactly sure how to add test, any help is appreciated.

Tests are not mandatory, but if you want to add some you'll need to basically create a dummy project in which to run the project detection commands. There are plenty of similar tests already.

I'll have to take a closer look at the code, but overall the PR seems reasonable to me.

bbatsov avatar May 21 '24 19:05 bbatsov

Let me know when you feel this is ready for another review.

bbatsov avatar Aug 24 '24 11:08 bbatsov