Fixing projectile-replace to respect .projectile

[palikar]

#1227 is a long standing issue and I've decided to give it a go. Previously the commands that are finding files with a certain pattern in them were ran on the entire project. Now I've modified the commands slightly so that they only check the files that are not ignored because of the .projectile file.

I am not sure if this is the best way to implement this. Feedback and other opinions will be welcomed.

---

• [x] The commits are consistent with our contribution guidelines
• [ ] You've added tests (if possible) to cover your change(s)
• [x] All tests are passing (make test)
• [x] The new code is not generating bytecode or M-x checkdoc warnings
• [x] You've updated the changelog (if adding/changing user-visible functionality)
• [ ] You've updated the readme (if adding/changing user-visible functionality)

[bbatsov]

I think it'd better to try to pass some ignores/includes to ag, then all the project files explicitly, as fetching the list, stitching it together and breaking it apart will probably rather slow.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding!

[orlandini]

Any updates/possible workarounds? It would be really useful to have it fixed but my lisp knowledge is quite limited.

[bbatsov]

I think a better solution would be pass the ignored stuff to the various tools as parameters, but this will be more involved in terms of code. The proposed solution will work fairly well on small projects, but will be extremely slow on something big.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding!

[stale[bot]]

This issues been automatically closed due to lack of activity. Feel free to re-open it if you ever come back to it.