Bozhidar Batsov

Results 1760 comments of Bozhidar Batsov

> What you said makes sense 🤔 It makes sense as an implementation for something like overriding the default test command, but I am not sure if it makes sense...

My preference is to avoid adding functionality for which there are no broad use-cases, as Emacs makes it easy for people to extend Projectile locally for their use-cases. As `projectile-test-project`...

Some basically this hook should fire when project files are written, right? Guess we can have a hook like this.

The reason why I haven't implemented this yet is simple - it's trivial to have the hook be triggered when writing files from Emacs, but it's more involved to trigger...

Yeah, nested projects are supported, but you might have to tweak the project resolution behaviour, as outlined here https://docs.projectile.mx/projectile/projects.html#customizing-project-detection Can you tell me what exactly gets detected as the project...

I like the idea in general, but I think it's a very bad idea to implement something just for one search tool, as it's confusing for the end users if...

The changes look reasonable to me, but you'll also have to mention them somewhere in the online docs, otherwise it's unlikely people will find this behavior. And the tests seem...

> I also updated the CHANGELOG file. Where can I update the online documentation? It's generated from the .adoc files in the `docs` folder.

@taquangtrung It seems the reference to `helm-grep-get-file-extensions` is breaking the CI. You might have to declare it or something like this.