Bozhidar Batsov
Bozhidar Batsov
My point is not 1.9 compatibility, but the fact that originally the suggested good syntax didn't work and therefore a lot of code was written without a space. I myself...
Great points! It's pretty similar to the problem with `X = Class.new`, which many tools won't understand as a class definition. > Even Rubocop doesn't recognize the assignment syntax everywhere...
> Can we consider adding this to the guide? Yes. But I think we already have [similar rules in the guide](https://github.com/bbatsov/ruby-style-guide#no-double-indent).
Agreed. I guess we can word this better and provide more examples.
I agree that's something to be avoided. I feel similarly about requiring stuff outside of the top-level scope.
I'd welcome improvements in this area. I thought we already had some rules that encourage the use of keyword params, but we can always do more.
I love this idea! We should definitely adopt a uniform language in this regard, even if it's exactly what's in RFC2119. P.S. Sorry the super late response! I haven't been...
Narrowing the type check feels like an anti-pattern to me, as it reduces the flexibility of the code. I'd advise against the use of explicit class checks. Let's see what...
> Both examples reflect legitimate needs of real world problems and both should be used where needed. Can't see any possible guided preference here. I don't see why in the...
Yeah, we can definitely add something along those lines, although I wouldn't use an example involving inheritance from String, as doing so is rarely a good idea. :-) A related...