Bozhidar Batsov
Bozhidar Batsov
The code looks OK to me overall. I guess we can proceed to documenting the new functionality before releasing it.
I don't know about the others, but I find the name `AllowImplicitArrayBrackets` to be a bit confusing. Isn't there some alternative terminology we can use here?
@rubocop/rubocop-core Any suggestions on the naming here, so we can unblock this?
Perhaps `AllowImplicitArrays` or `AllowImplicitArrayLiterals`?
Yeah, I think at some point there was even a suggestion for RuboCop to process editorconfig files, which is probably not a horrible idea. At any rate, I think for...
@dvandersluis You've got it!
> I understand that it shouldn't breaking change until 2.0, but I believe this is worth the breaking change for early adopters using pending cop. I'll have to think about...
> There's a fix in master pending a new release. What fix are you referring to?
It's interesting that this was working at all before, and not raising an error for the obsolete cop's name. It's the changes in #14006 actually helped discover a problem with...
> However, I think it still used to work JRE, so it's a bug that resurfaced. @alexander-yakushev I think the parser logic depends on some JDK classes, but my memories...