adoc-mode icon indicating copy to clipboard operation
adoc-mode copied to clipboard

Published 20 hours ago • verified publisher icon bbatsov

Replace title and table sregexp to rx samples

Open dunmaksim opened this issue 1 year ago • 4 comments

  • Added rx builtin library.
  • RegExp's for title level 0-5 builded with rx.
  • RegExp for code and tables builded with rx.
  • Updated local variables code (like dns-mode.el).

close #24

dunmaksim avatar Apr 05 '23 09:04 dunmaksim

You should also check the CI error - seems some rx invocation is incorrect.

bbatsov avatar Apr 07 '23 06:04 bbatsov

Adding a few unit tests covering your changes would be nice as well.

bbatsov avatar Apr 07 '23 06:04 bbatsov

Perhaps it is worth closing this PR and opening it again after fixing all issues.

Should I remove the 'adoc-calc` function?

dunmaksim avatar Apr 07 '23 06:04 dunmaksim

Perhaps it is worth closing this PR and opening it again after fixing all issues.

Up to you - I don't mind keeping it open and marked as draft.

Should I remove the 'adoc-calc` function?

Yep.

bbatsov avatar Apr 07 '23 07:04 bbatsov