retools icon indicating copy to clipboard operation
retools copied to clipboard

Completed 2to3 conversion without running tests

Open cacods opened this issue 3 years ago • 3 comments

Applied 2to3 to convert from Python 2 to Python 3. Python 3 version used: 3.5.2.

cacods avatar Dec 11 '20 18:12 cacods

I guess this presents the question of whether the goal is to still support Python 2. If that was the goal then six should probably be used to handle both versions since changing the unicode to str will definitely break existing users still on Python 2. I'm fine moving to Python 3 only support and dropping Python 2 if we move that to a new branch and version to reflect it just so that Python 2 users do not inadvertently get broken.

bbangert avatar Dec 14 '20 19:12 bbangert

As Python 2 was gone last year, I think is a good idea to have a separate version and branch for Python 3.

cacods avatar Dec 16 '20 15:12 cacods

@cacods agreed.

bbangert avatar Jan 04 '21 17:01 bbangert