jorani icon indicating copy to clipboard operation
jorani copied to clipboard

Enhancement - Multi step approvals

Open rickpratt opened this issue 7 years ago • 12 comments

Allowing team leads, junior managers etc to approve leave and have an overall signoff by a more senior level would help remove the backlog of leave that come into a single person.

rickpratt avatar Feb 01 '18 08:02 rickpratt

This is very neccessary in real life. For example, team leaders can only approve 1 day leave, department managers can only approve 3 days, etc. It should has a automated approval workflow according the configurable leave days.

fishfree avatar Sep 11 '18 21:09 fishfree

Please draft a detailed document. And then you are encouraged to submit a PR. Contributing to open source projects is very necessary in the real life.

Le mer. 12 sept. 2018 à 04:37, fishfree [email protected] a écrit :

This is very neccessary in real life. For example, team leaders can only approve 1 day leave, department managers can only approve 3 days, etc. It should has a automated approval workflow according the configurable leave days.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bbalet/jorani/issues/240#issuecomment-420434148, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKjqkEPZ-LgxdQTuWdkCUqYnPVd7iAeks5uaC0LgaJpZM4R1N6_ .

bbalet avatar Sep 11 '18 23:09 bbalet

Hello everyone, Does jorani V0.6.5 support multi-steps leave approval ?

ShivCharanSharma avatar Jun 17 '19 06:06 ShivCharanSharma

@ShivCharanSharma no it doesn't. This feature is low priority for the project.

bbalet avatar Jun 17 '19 08:06 bbalet

HI @bbalet Thanks for quick reply. I want to add this feature in jorani. I can spend 8 hours per day. Any pointer in right direction will be really helpful. Thanks

ShivCharanSharma avatar Jun 17 '19 08:06 ShivCharanSharma

You should start to draft a proposal with some mockups:

  • It must optional.
  • The user create/edit forms should have a new field(s) (impact on DB model).
  • 2 levels or multi-level? If multi-level, what is the workflow exactly? I mean the order of the managers is important or not (AND or OR)?
  • What about the different emails sent
  • Is there any change into the WebUI besides the user management part? I think it should appear in the profile page. And the employee should have something telling him/her where his/her request is stuck.
  • What about the reminder email?
  • Another user in this thread suggested something automated depending on the leave type. Does it mean some types can be directly accepted by the line manager?
  • Is it somehow related to the organisation or completely decoupled as of today?

Before starting to code I think that there is a lot of unanswered questions.

bbalet avatar Jun 17 '19 09:06 bbalet

Thank you @bbalet, I also waiting this feature and I will help you to answer that question.

thanks so much.

konrasee avatar Jun 28 '19 08:06 konrasee

This Multi -Approval Feature would be really helpful in most organizational standpoint ..... Also eagerly waiting for this feature, Thanks @bbalet

Odarlie avatar Jul 16 '19 08:07 Odarlie

looking at the organization table, i can see there's a column named supervisor but the values are all NULL.

Is this currently in used? Is it possible to set this in the web interface so that supervisor of an entity are automatically managers of employees in that entity?

mrazishere avatar Aug 13 '19 20:08 mrazishere

If you look into the page HR/organization you will see that this field is used for notifications purpose.

Le mer. 14 août 2019 à 03:09, asriznet [email protected] a écrit :

looking at the organization table, i can see there's a column named supervisor but the values are all NULL.

Is this currently in used? Is it possible to set this in the web interface so that supervisor of an entity are automatically managers of employees in that entity?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bbalet/jorani/issues/240?email_source=notifications&email_token=AAJKHKXMHSNPY43LUH3XMH3QEMIGRA5CNFSM4EOU3272YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4G2VXQ#issuecomment-520989406, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJKHKSM7TX2JCTRQJRDD4TQEMIGRANCNFSM4EOU327Q .

bbalet avatar Aug 14 '19 00:08 bbalet

If you look into the page HR/organization you will see that this field is used for notifications purpose. Le mer. 14 août 2019 à 03:09, asriznet [email protected] a écrit : looking at the organization table, i can see there's a column named supervisor but the values are all NULL. Is this currently in used? Is it possible to set this in the web interface so that supervisor of an entity are automatically managers of employees in that entity? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#240?email_source=notifications&email_token=AAJKHKXMHSNPY43LUH3XMH3QEMIGRA5CNFSM4EOU3272YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4G2VXQ#issuecomment-520989406>, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJKHKSM7TX2JCTRQJRDD4TQEMIGRANCNFSM4EOU327Q .

Yes I did see that however I was never successful in received the notification, Email test script is successful and I'm able to receive the test message but none of the notification email when user submit a request.

mrazishere avatar Aug 14 '19 08:08 mrazishere

+1 This would be very useful, all request in my workplace must be approved by manager AND the HR dept. Looking forward to this.

toxiclung avatar Jul 18 '20 06:07 toxiclung