jorani
jorani copied to clipboard
bbalet
'All Day' event in ICS feed not handled correctly in apps
When using the ICS feed for a given calendar, the events are set to begin at 12:01 and end at 11:59 of the same day. While this seems intuitive, applications are not handling the 23 hour, 58 minute event as "all day".
The underlying VObject library has a solution for handling this, linked below.
- Related: https://github.com/fruux/sabre-vobject/issues/184
- Relevant Code: Reference: https://github.com/bbalet/jorani/blob/master/application/controllers/Ics.php#L229-L232
Outlook
iCal
Why not submitting a PR?
I've found that it's much better to file an issue and receive feedback first. For example, you or other contributors may have a very good reason for this behavior. Or it may be a known issue that I couldn't track down in the handful of 🇫🇷 tickets that have been submitted 😁. I'm also not ramped up on this particular platform (I'm an end user, not the admin), so it may have been a setting I wasn't aware of.