bbaldino
bbaldino
@chrysn bump
Sounds reasonable to me. I'll try and take a look at adding this.
cool, will take a look through this. i wonder, though, if we want to think about how we accomplish this sort of thing in the bigger picture of the other...
Did you run into an issue with the SCTP threading that prompted this?
Thanks, this is interesting. Do you have an example PR you could link which shows what it looks like when a spelling error is caught? I know you linked to...
> That's a good point, I should have a good showcase. Here's a simple example: > > In [microsoft/terminal#5485](https://github.com/microsoft/terminal/pull/5485), [github-actions commented](https://github.com/microsoft/terminal/pull/5485#commitcomment-38684451) and left [annotations](https://github.com/microsoft/terminal/commit/f343e2476c5308df4fa4eba89d8969285c149ec6#diff-e8986dd365aa23a5fbc39a8f26e76d58R39). > > Fwiw, the doubled annotation...
Thanks for this report, we recently saw we're encountering the same issue. A fix will likely be merged today (slightly different than what you have in #1484 , but thank...
Fix is in https://github.com/jitsi/jitsi-videobridge/pull/1485
> during our test, I can see ByteBufferPool upto 3000+... is this a memory leak? meaning jvb won't be able to recover the heap memory during garbage collection? > @bbaldino...
> so it is possible that jvb heap memory (default 3GB) will be consumed by this buffer allocation when it received a continuous large buffer that is more than 1500...