Brad Baker

Results 214 comments of Brad Baker

Looking into this it gets a little tricky in terms of what "context" is available. For example `graphql.schema.Coercing#serialize`` is only ever called during query execution phase and hence all the...

Lets leave this open UNTIL we merge that PR - its likely but not yet done

So its a completely crazy idea.... le is think on it. But you can kinda do this today via CompletableFuture. The DataFecthers in graphql-java handle a number of different types...

eg ``` static CompletableFuture closeableSupport(Object value) { CompletableFuture cf; if (value instanceof CompletionStage) { cf = ((CompletionStage) value).toCompletableFuture(); } else { cf = CompletableFuture.completedFuture(value); } return cf.thenAccept(val -> { if...

Great point - you cant use the code above. It would close it before it was processed Scratch that idea.

This is a great point you have brought up. Some of the `GraphQLError` instances will always have n on null locations and some do not. The error builder in question...

The Parser i18n code is now master - so there is more i18n keys to translate

The challenge we have is that we want things to be async AND we want them to run late and lazy AND we want to have a happens before relationship...

Looking ahead is not cheating - its often the best to optimise since your code is able to KNOW that dependent objects will be needed by looking at the query....