MemoryModulePP icon indicating copy to clipboard operation
MemoryModulePP copied to clipboard

Fixed crash on invalid hash table

Open CycloneRing opened this issue 11 months ago • 0 comments

Hi @bb107 while using mmpp I faced a crash in my application on initialization when another dll was loaded. I investigated the issue and found the root, I applied a fix that made the application work perfectly however i'm not sure what is exactly the issue however the hashtable is null. by returning in will work later. You may want to check this and make a better fix.

also there was a crash on exit from ntrtl.h which the code doesn't make sense to me

    Flink = Entry->Flink;
    Blink = Entry->Blink;
    Blink->Flink = Flink;
    Flink->Blink = Blink;

I fixed it by validation

if (!Entry) return FALSE;

And I believe it must be

    Blink->Flink = Flink;
    Flink->Blink = Blink;
    Entry->Flink = NULL;
    Entry->Blink = NULL;
  

CycloneRing avatar Jan 15 '25 17:01 CycloneRing