jaydebeapi icon indicating copy to clipboard operation
jaydebeapi copied to clipboard

Published 20 hours ago • verified publisher icon baztian

Updated code from #116 to get it merged.

Open cocampbe opened this issue 4 years ago • 4 comments

Really need ability to pass java_opts. I saw #116 and decided to make the corrections.

cocampbe avatar Jun 02 '21 17:06 cocampbe

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Jun 02 '21 17:06 sonarqubecloud[bot]

Good, bad, ugly?

cocampbe avatar Jun 07 '21 11:06 cocampbe

Thanks @cocampbe it actually looks good to me. Unfortunately I'm having issues with the Jython builds. But this is not due to one of your changes but to some incompatibilities introduces in some lib used during build. So I'm wondering if I finally should drop Jython support.

baztian avatar Jun 10 '21 21:06 baztian

Hey @baztian, my team also need the ability to specify Java options.

Seems like this feature is frequently requested by consumers of JayDeBeAPI as there has been number of pull request for this (#116 and #166)

If this change looks good, could you merge the pull request and publish a new version, please?

Thank you.

kouddy avatar Nov 29 '21 18:11 kouddy