ejs-compiled-loader
ejs-compiled-loader copied to clipboard
bazilio91
In search of collaborator
Anybody wants to become a contributor/collaborator? I have no interest to support this package now (I'm on DevOps title right now). I can't track all the changes that came in webpack.v2/es6.
I might be able to help, but I'm a bit confused. The version installed from npm with npm install ejs-compiled-loader is version 1.1.0. That's also the version I got from running yarn add ejs-compiled-loader@latest. However, this repository defaults to the 2.x branch. Is that intentional? Is there a reason that npm doesn't default to the 2.x branch as well?
Second, I see the 2.2.0 version still uses the include path/to/file syntax from ejs 1.x, is that just because it hasn't been updated to the newer include('path/to/file', {options}) syntax, or is that a design decision?
@Adam-Meisen there is nothing in this design we can't change. I'm looking to find some time now to setup travis or circle to automate releases for this repo and invite some more collabs. Are you still interested?
The version installed from npm with npm install ejs-compiled-loader is version 1.1.0
Looks like it is default behaviour when you do npm publish, no matter if it is 1.x or 2.x, the last one was 1.1.0
I'm interested. I would like to set up CI to get #32 and #34 squared away.
I'm also interested in contributing. I use this loader in my project and it's quite useful.
As a matter of facts I forked the repo already and implemented the changes needed to support webpack@4 It's here if you want to try it out. I haven't updated the README yet.
It's published on npm as @piccio/ejs-compiled-loader version 3.0.0.
If there's interest I can make a PR. @bazilio91 let me know
@vagusX I haven't heard from @bazilio91 but I'm using https://github.com/piuccio/ejs-compiled-loader in production and works fine for me with webpack 4
npm i @piuccio/ejs-compiled-loader
@piuccio this repo is still getting lots of downloads, and I have some time now to get this solved, will u join this repo to maintain it with some other guys who is interested in it and maintaining own forks?
Sure, I don't use it anymore but I can at least merge back the changes for webpack 4 and delete my fork
On Fri, 10 Apr 2020, 05:48 Vasily Ostanin, [email protected] wrote:
@piuccio https://github.com/piuccio this repo is still getting lots of downloads, and I have some time now to get this solved, will u join this repo to maintain it with some other guys who is interested in it and maintaining own forks?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bazilio91/ejs-compiled-loader/issues/25#issuecomment-611745372, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFGCXDBSNDT2TMJQH5WYHDRLYYDVANCNFSM4C27GFGA .