trunk icon indicating copy to clipboard operation
trunk copied to clipboard

grpc_proto.bzl out of date?

Open pcj opened this issue 8 years ago • 6 comments

I cloned the repo/submodules and tried to build the examples. It fails quickly with the following error. I am building with bazel 0.3.1rc2, but the same error occurs with 0.3.0. I have not tried earlier bazel versions.

bazel build examples/...:all
trunk/third_party/grpc/grpc_proto.bzl:116:12: Attribute 'attrs' either doesn't exist or uses a select() (i.e. could have multiple values)
Available attributes: $protoc, :action_listener, compatible_with, deprecation, deps, expect_failure, features, gen_cc, gen_java, generator_function, generator_location, generator_name, grpc_cpp_plugin, grpc_java_plugin, has_service, restricted_to, src, tags, testonly, visibility

pcj avatar Jul 28 '16 16:07 pcj

Also see https://groups.google.com/d/msg/bazel-discuss/Crs4RNqHoCI/7Otj-W-6BgAJ

pcj avatar Jul 30 '16 04:07 pcj

I was able to repro this locally as well.

claudiouzelac avatar Aug 04 '16 00:08 claudiouzelac

Yeah i have been running into a slew of different issues building this with 0.3.1. However the examples are great and pretty easy to fix once you take a look over things. Not sure if this project aims to support 0.3.1 it looks like it's stuck at testing against 0.2.2 right now.

michaeljs1990 avatar Aug 14 '16 17:08 michaeljs1990

Yeah, I realize it's kind of out of date. We are slowly picking up 0.3.1 internally. So hopefully I will take a chance to fix this issue in a few days.

mzhaom avatar Aug 15 '16 05:08 mzhaom

@mzhaom your boost stuff helped me out significantly. I have added a few more libraries in my repo here https://github.com/michaeljs1990/clog/tree/master/third_party/boost if of any use to you.

michaeljs1990 avatar Aug 15 '16 16:08 michaeljs1990

@michaeljs1990 likewise and nice work! I'm going to pull that over into my fork to hack on.

claudiouzelac avatar Aug 15 '16 22:08 claudiouzelac