vscode-bazel icon indicating copy to clipboard operation
vscode-bazel copied to clipboard

make output_base directory configurable

Open sheldonneuberger-sc opened this issue 3 years ago • 2 comments
trafficstars

Adds an outputBase string configuration that changes where output_base is placed. This is convenient for when someone wants bazel using something other than TMPDIR. This is useful if you use a ramdisk for faster builds, or if your TMPDIR has space or security constraints.

sheldonneuberger-sc avatar Sep 16 '22 04:09 sheldonneuberger-sc

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Sep 16 '22 04:09 google-cla[bot]

Are you able to sign the CLA?

Yes, we (snapchat) have signed it before but last I checked we lost the details of it. Might take a few days to figure it out again.

sheldonneuberger-sc avatar Sep 19 '22 18:09 sheldonneuberger-sc

Got myself onto the CLA list, I believe this can be merged now.

sheldonneuberger-sc avatar Jan 24 '23 21:01 sheldonneuberger-sc

Looks like now CI is complaining about a code style issue. This line is exeeding 80 characters (sorry we don't have autoformatting set up yet):

https://github.com/bazelbuild/vscode-bazel/blob/076e3432f306f5fd44a93a021cfea4c6a5b87ba9/src/bazel/bazel_query.ts#L132

jfirebaugh avatar Jan 24 '23 23:01 jfirebaugh