vim-ft-bzl

vim-ft-bzl copied to clipboard

Avoid matching lowercase files when fname_case feature is missing

4

Put the BUILD, *.BUILD, and BUILD.* patterns behind a has('fname_case') check so that on case-insensitive systems it doesn't false positive on lowercase names. "build" is kind of a generic pattern...

dbarnett

Bazel file detection defeated by MacVim's filetype.vim

1

After installing this plugin and opening a *.bzl file in MacVim, I get: ``` vim :verbose set ft? ``` ``` filetype=conf Last set from /Applications/MacVim.app/Contents/Resources/vim/runtime/filetype.vim ``` I'm currently working around...

patspam

Add test coverage for autoindent

2

We should cover the `indentexpr` functionality with a vroom test. I already broke it once.

dbarnett

With spell checking enabled in bzl files, you see a lot of spelling errors reported due to the fact that most strings in bzl are paths or other special names....

dbarnett

`indent/python.vim` is only executed once per vim instance: https://github.com/bazelbuild/vim-ft-bzl/blob/941fb142f604c254029c2a0852ea7578f08de91a/indent/bzl.vim#L23-L25 but it should really be executed once per buffer, because it sets `autoindent` and `GetPythonIndent` (actually `python#GetIndent` these days) relies on...

liskin