tulsi icon indicating copy to clipboard operation
tulsi copied to clipboard
verified publisher icon bazelbuild

BUILD files are added even when using BUILD.bazel files

Open DavidGoldman opened this issue 7 years ago • 4 comments

See https://github.com/dflems/bazel-repro/tree/master/tulsi-local-repo for an example project.

When using BUILD.bazel files (i.e. package/BUILD.bazel), Tulsi adds both package/BUILD and package/BUILD.bazel as file references in the Xcodeproj even though only the BUILD.bazel file exists.

DavidGoldman avatar Mar 01 '18 15:03 DavidGoldman

Taking a quick look into this, we forcibly add a BUILD file as an additionalFilePath for every package in your project when you create it. We can probably remove this altogether or check for file existence before we add it.

See the relevant UI code and CLI code.

DavidGoldman avatar Mar 01 '18 22:03 DavidGoldman

@DavidGoldman I am sure you might have figured this out, but for everyone's reference -- one workaround for this issue is...

  1. Open .tulsigen file(s) under Configs directory in the Tulsi project.
  2. Rename files from BUILD to BUILD.bazel in additionalFilePaths section.
  3. And then generate the Xcode project from GUI or CLI.

ravimandala avatar Oct 12 '18 02:10 ravimandala

As an alternative workaround you can modify the two codepaths I listed above and replace"BUILD" with "BUILD.bazel" or perhaps this could be some Tulsi config setting.

DavidGoldman avatar Oct 12 '18 13:10 DavidGoldman

Tulsi needs to support the use of either BUILD or BUILD.bazel, so it's more than replacing BUILD with BUILD.bazel.

ravimandala avatar Oct 17 '18 19:10 ravimandala

Thanks for submitting this issue but this tool is being deprecated. Please checkout rules_xcodeproj for a more complete and maintained Xcode integration.

keith avatar Feb 15 '23 17:02 keith