rules_webtesting icon indicating copy to clipboard operation
rules_webtesting copied to clipboard

Flag --incompatible_config_setting_private_default_visibility will break rules_webtesting in Bazel 7.0

Open keertk opened this issue 2 years ago • 7 comments

Incompatible flag --incompatible_config_setting_private_default_visibility will be enabled by default in the next major release (Bazel 7.0), thus breaking rules_webtesting. Please migrate to fix this and unblock the flip of this flag.

The flag is documented here: https://github.com/bazelbuild/bazel/issues/12933.

Please check the following CI builds for build and test results:

Never heard of incompatible flags before? We have documentation that explains everything. If you have any questions, please file an issue in https://github.com/bazelbuild/continuous-integration.

keertk avatar Nov 23 '22 21:11 keertk

This project is on an old rules_go release; after its deps are updated, I think this will be ok

joshbruning avatar Nov 23 '22 21:11 joshbruning

I tried building with today's rules_go release; however, there will need to also be a new bazel-gazelle (not yet released) due to (at least) https://github.com/bazelbuild/rules_go/pull/3276

joshbruning avatar Nov 23 '22 22:11 joshbruning

@joshbruning hi, are you still a maintainer here? I noticed this issue is 6mo old, I am sure any changes you need from rules_go and bazel-gazelle have been released.

alexeagle avatar May 22 '23 20:05 alexeagle

No, I haven't been for some years; @mtrea - I think you should try updating the version set and trying a build at least (it may end up being easy); the version diff is getting bigger, and will eventually make the update more difficult to do in one-shot, and there have been an increasing number of linter headaches

joshbruning avatar May 22 '23 20:05 joshbruning

Hi @joshbruning, Could you please look in to this issue.Thanks!

sgowroji avatar Jun 19 '23 04:06 sgowroji

I'm not a maintainer.

joshbruning avatar Jun 19 '23 09:06 joshbruning

@mtrea Can you Please have a look on the above failures. Thanks!

sgowroji avatar Aug 21 '23 08:08 sgowroji