bazelbuild
Remove uses of `incompatible_use_toolchain_transition` now that it is enabled by default.
This is a step towards removing it entirely.
PiperOrigin-RevId: 406230375 (cherry picked from commit d1ba795ff479881bf14ba70294693dcabace4fd4)
Lyft integration job started: https://buildkite.com/lyft/rules-swift/builds/165 (must be Lyft employee to view)
The flag has been flipped, and we only support 5.0 and above now, so I thought it's on the table again? This PR can just sit here if it's not the time yet.
We could wait until the flag doesn't exist anymore, to prevent issues for users that somehow need the flag in the other state. Maybe that was the end decision of delaying this externally.
@Keith Thoughts on merging now, or waiting until the flag it dropped entirely (i.e. 6.0)?
it's unnecessary with 5.x right? if so i agree we should merge now since we already broke 4.x compat
A user of Bazel 5.0 might set --incompatible_override_toolchain_transition=false, changing away from the default, and then rules_swift would stop working for them.
hm yea interesting case. i wonder how prevalent that will be. no strong pref since this change likely won't help from a conflicts perspective, so there's no rush to merge it IMO (until last_green breaks compat maybe)
until last_green breaks compat maybe
Yeah, we will have to make a call then. Probably worth merging at that time over forking 5.0 from 6.0.
--incompatible_override_toolchain_transition is now a no-op in 6.0, but still available in 5.x. We can merge this once we break 5.x compatibility.