rules_swift
rules_swift copied to clipboard
bazelbuild
Add `aspect_hints` feature
This includes all the upstream commits related to this, which is blocked on bazel's default for this feature
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.
We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.
Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).
ℹ️ Googlers: Go here for more info.
![google-cla[bot] avatar](https://avatars.githubusercontent.com/in/42202?v=4 "Published by a pub.dev verified publisher"){kind=small}
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.
We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.
Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).
ℹ️ Googlers: Go here for more info.
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.
We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.
Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).
ℹ️ Googlers: Go here for more info.
https://github.com/bazelbuild/bazel/commit/47bd65adf6fd968c9eb84f96044050d852750d62
Many other changes rely on this now. Let's enable the flag and mention about this requirement in the release notes.
I'm not sure we want to force that flag on all users of rules_swift. Let's see if @allevato has any additional thoughts.
I'm not sure we want to force that flag on all users of rules_swift. Let's see if @allevato has any additional thoughts.
The only real advice I can offer is to bring up to the Bazel team the difficulty the experimental nature of the feature poses to integrating upstream rules_swift changes (especially as they stack on each other). Unfortunately the decision to make the flag experimental in Bazel was made some time after the feature was implemented and the Swift rules had started adopting it...
Lyft integration job started: https://buildkite.com/lyft/rules-swift/builds/244 (must be Lyft employee to view)
Lyft integration job started: https://buildkite.com/lyft/rules-swift/builds/245 (must be Lyft employee to view)
Lyft integration job started: https://buildkite.com/lyft/rules-swift/builds/247 (must be Lyft employee to view)
Lyft integration job started: https://buildkite.com/lyft/rules-swift/builds/343 (must be Lyft employee to view)
Lyft integration job started: https://buildkite.com/lyft/rules-swift/builds/345 (must be Lyft employee to view)
Lyft integration job started: https://buildkite.com/lyft/rules-swift/builds/347 (must be Lyft employee to view)
Lyft integration job started: https://buildkite.com/lyft/rules-swift/builds/350 (must be Lyft employee to view)
Dang i think this is blocking cherry-picking https://github.com/bazelbuild/rules_swift/commit/bfcae19af93924651911e6bdc669608e9453a774 as well.
