rules_scala
rules_scala copied to clipboard
bazelbuild
Get jar label from manifest stamp when present
This PR gets a jar's label from the 'Target-Label' MANIFEST.MF attribute when available (this is what java_common.{run_ijar,stamp_jar} both populate).
looks like this breaks some tests we have around unused dependencies.
Can you inspect those errors and see about fixing those tests? It may be that the test is over strict, or it may be that something really broke.
I’ll take a look at the impl but in general this is definitely something I want to do (switch to label lookup from manifest rather than passing labels). Note that we need to use stamp_jar in scala_import and scala macro library. Also this will break some tests which talk about exports but maybe that’s the price we need to pay On Mon, 18 Mar 2019 at 22:55 P. Oscar Boykin [email protected] wrote:
looks like this breaks some tests we have around unused dependencies.
Can you inspect those errors and see about fixing those tests? It may be that the test is over strict, or it may be that something really broke.
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/bazelbuild/rules_scala/pull/716#issuecomment-474097122, or mute the thread https://github.com/notifications/unsubscribe-auth/ABUIF0Oj91xa5zR8Pn8xGr4wRvLpvD37ks5vX_0mgaJpZM4b6lv4 .
This is still interesting but has seemed to get a bit stale.
@ittaiz can you take a look, and @ceason can you merge master?
@ittaiz is there someone on your end that can look at this? I know the skylark label propagation is something you all wanted. It would be great to switch to the same approach that java is using.
cc @andyscott @long-stripe if you are looking for clean up tasks. :)
We wanted it but due to disagreements with upstream java people we've dropped the usage. Essentially we allow label re-mapping (via export) whereas they determine the label at point of creation. @or-shachar maybe this is a relevant task for Shay? It will take him through a few of the interesting places.
I think I’ll have someone in a month. If Long or Andy want to give it a crack I’ll be happy to guide them
