rules_scala icon indicating copy to clipboard operation
rules_scala copied to clipboard

Allow scala_benchmark_jmh to specify a runtime_jdk version

Open wiwa opened this issue 3 years ago • 0 comments
trafficstars

Description

Include runtime_jdk as an an attr on jmh_support:benchmark_generator. scala_benchmark_jmh can now specify a Java runtime to build its scala_binary with.

To test whether our changes work for different specified JDKs, we include [email protected] as an http_archive. We don't override our Bazel's (@.bazelversion) rules_java and instead pull in the newer rules_java as @rules_java_extra.

This allows us to use remote_jdk8 runtimes specified here.

Motivation

We want to be able to use JMH benchmarking on different Java runtimes.

Co-authored-by: Shane Delmore [email protected]

wiwa avatar Sep 21 '22 02:09 wiwa