rules_rust icon indicating copy to clipboard operation
rules_rust copied to clipboard

FR(crate_universe): honor .bazelignore and REPO.bazel ignore_directories

Open alexeagle opened this issue 3 months ago • 5 comments

The splicer can ignore crates (Cargo.toml files) that appear in certain fixed paths:

https://github.com/bazelbuild/rules_rust/blob/3585384b93cf10c6e5b1c1ba07d7405e596bd6d6/crate_universe/src/splicing/splicer.rs#L42

If a directory is bazel-ignored, then the splicer should skip that too.

alexeagle avatar Sep 03 '25 20:09 alexeagle

I've hit this issue too. @alexeagle did you find a workaround? (beyond just patching rules_rust)

rdelfin avatar Nov 03 '25 16:11 rdelfin

No, I've been trying dzbarsky/rules_rs to workaround this and other problems with the splicer.

alexeagle avatar Dec 03 '25 23:12 alexeagle

Pull requests are welcome!

UebelAndre avatar Dec 04 '25 00:12 UebelAndre

They are - but then there aren't enough maintainers helping to review them ;) Here to help 🙇🏻

alexeagle avatar Dec 04 '25 00:12 alexeagle

Since the problem and use case is clear for this issue. I promise to review a change to implement this and approve given sufficient test coverage. It seems straight forward enough which is a refreshing break from most new issues (this is where maintainer bandwidth wanes) 😅

UebelAndre avatar Dec 04 '25 00:12 UebelAndre