rules_rust icon indicating copy to clipboard operation
rules_rust copied to clipboard

add rustdoc feature support

Open TroyKomodo opened this issue 5 months ago • 1 comments

  • Adds crate_features to be saved as part of CrateInfo
  • Adds new flags for rust_doc and rust_doc_test to include the features of the crate when building the docs (enabled by default)

This is my first time using bazel so I am not 100% sure of my work, feedback greatly appreciated.

fixes #511

TroyKomodo avatar Jun 16 '25 03:06 TroyKomodo

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jun 16 '25 03:06 google-cla[bot]

@illicitonion the error here looks spurious

TroyKomodo avatar Jul 12 '25 16:07 TroyKomodo

Thanks for the test!

I agree the failures look unrelated, unfortunately we have no way of bypassing or rerunning CI ourselves, but if you can push either empty commits or merge-main commits to this branch until things go green, that'd be super handy! (I'd do this myself, but I don't have permission to push to your fork)

illicitonion avatar Jul 12 '25 22:07 illicitonion

Oh there is a buildifier error though :)

illicitonion avatar Jul 12 '25 22:07 illicitonion