rules_rust icon indicating copy to clipboard operation
rules_rust copied to clipboard

crate_universe builds not forwarding environment variables from `env` section of `cargo_config` ?

Open sthornington opened this issue 1 year ago • 2 comments

We have TIMENS_TZ_FILTER set in the env section of the cargo_config toml file, but it doesn't appear to be getting forwarded to the cargo build of the timens crate - is this section supported by rules rust?

sthornington avatar Sep 25 '24 14:09 sthornington

Ah, that’s definitely something I didn’t think about. I think if the config is in the repo then it would be fair to render the environment variables but what about configs on the system (~/.cargo/config.toml)? I feel like those should be ignored?

I’m happy to review a PR for this :)

UebelAndre avatar Sep 25 '24 15:09 UebelAndre

Understood, any hints on where to begin would be appreciated. I didn't think that system cargo configs were even parsed? There's that error that emits if one is even in the parent directories of the bazel workspace?

sthornington avatar Sep 25 '24 22:09 sthornington