rules_rust icon indicating copy to clipboard operation
rules_rust copied to clipboard

Coverage on CI builds manual targets

Open tidefield opened this issue 1 year ago • 0 comments

Apparently, our coverage CI targets build the manual targets which are only intended for analysis tests. See https://buildkite.com/bazel/rules-rust-rustlang/builds/10609#018db017-013b-47b3-8ff0-13d7ee74d774 for the error

(05:20:02) ERROR: /Users/buildkite/builds/bk-imacpro-15/bazel/rules-rust-rustlang/test/bindgen/BUILD.bazel:3:19: Compiling Rust bin test_cc_linkopt_rust_binary (1 files) failed: missing input file '//test/bindgen:main.rs'
--
  | (05:20:02) ERROR: /Users/buildkite/builds/bk-imacpro-15/bazel/rules-rust-rustlang/test/bindgen/BUILD.bazel:3:19: Compiling Rust bin test_cc_linkopt_rust_binary (1 files) failed: 1 input file(s) do not exist
  | (05:20:02) ERROR: /Users/buildkite/builds/bk-imacpro-15/bazel/rules-rust-rustlang/test/bindgen/BUILD.bazel:3:19 Compiling Rust bin test_cc_linkopt_rust_binary (1 files) failed: 1 input file(s) do not exist

Apparently, our test/ folder has a mixed bag of both analysis tests and examples. Analysis tests should mostly include manual targets which shouldn't require any inputs at all. A holistic fix should be drawing the clear borderline so that bazel coverage doesn't run against the manual targets. @UebelAndre I remember you talking about this at some point. Do you have suggestion what we should do here?

cc: @scentini

tidefield avatar Feb 19 '24 16:02 tidefield