rules_rust icon indicating copy to clipboard operation
rules_rust copied to clipboard

Published 20 hours ago • verified publisher icon bazelbuild

feat: Add `crate_features` attr to `rust_doc` rule

Open ParkMyCar opened this issue 2 years ago • 2 comments

This PR adds the crate_features attr to the rust_doc rule, which allows you to specify what features should be enabled when building docs. Currently rust_doc doesn't enable any features (as far as I can tell, not even default features) which makes it impossible to build docs when a feature isn't available on the platform you're currently running on.

ParkMyCar avatar Jul 28 '22 16:07 ParkMyCar

Hey @illicitonion, any chance you could review this PR too? No rush though :)

P.S. I tried to assign a reviewer but I don't seem to be able to

ParkMyCar avatar Aug 01 '22 15:08 ParkMyCar

Could we add a test please?

Great idea! I added a unit test, please let me know if there is a different test or an example I should add

ParkMyCar avatar Aug 01 '22 20:08 ParkMyCar