rules_rust icon indicating copy to clipboard operation
rules_rust copied to clipboard

Include generated snippets from wasm_bindgen

Open rharink opened this issue 3 years ago • 1 comments

When generating wasm bindings for targets web or bundler a snippets directory is created containing imports related to the generated bindings.

This fix includes the snippets directory in the Bazel output, so it can be used by other targets.

rharink avatar May 19 '22 09:05 rharink

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

google-cla[bot] avatar May 19 '22 09:05 google-cla[bot]

@rharink are you still interested in trying to get this in? Based on my very limited usage of wasm_bindgen and hitting this issue, I'm hoping this can get merged (and I can remove the local patch) 🙂

rickvanprim avatar Dec 09 '22 07:12 rickvanprim

@rickvanprim Hi, yeah I'm also working with a local patch 😅. Got lost in work. Ill try and pick this up asap.

rharink avatar Dec 09 '22 08:12 rharink

Hello, is this still a desired change? 😄

UebelAndre avatar Apr 11 '23 13:04 UebelAndre

Hello, is this still a desired change? 😄

I would still find this useful 🙂 One less patch 😅

rickvanprim avatar Apr 12 '23 00:04 rickvanprim