rules_python icon indicating copy to clipboard operation
rules_python copied to clipboard

wip: target_platforms fixup

Open aignas opened this issue 2 weeks ago • 1 comments

WIP: Simple behaviour fixup for default values.

  • fixup the target_platform setting and test locally
  • fixup

aignas avatar Dec 08 '25 23:12 aignas

Summary of Changes

Hello @aignas, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the target_platforms configuration within the Bazel build system, particularly for Python-related dependencies and documentation builds. The changes ensure that default platform settings are applied consistently, addressing a 'work in progress' fixup for behavior related to these default values.

Highlights

  • Platform Configuration for dev_pip: The dev_pip extension in MODULE.bazel now explicitly defines target_platforms to include both generic OS/architecture and freethreaded variants, ensuring consistent platform setup for Python dependencies.
  • Documentation Build Settings: The sphinx_build_binary rule in docs/BUILD.bazel has been updated to include PY_FREETHREADED and set PYTHON_VERSION to '3.14' within its config_settings, affecting how documentation is built.
  • Dynamic target_platforms Defaulting: The _pip_parse function in python/private/pypi/hub_builder.bzl now includes revised logic for target_platforms, defaulting to ["{os}_{arch}"] if pip_attr.target_platforms is not provided and default_cross_setup is false, otherwise using an empty list. This clarifies default behavior for platform targeting.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 08 '25 23:12 gemini-code-assist[bot]