rules_python icon indicating copy to clipboard operation
rules_python copied to clipboard

testing windows + bazel 8

Open rickeylev opened this issue 1 month ago • 4 comments

wip

rickeylev avatar Nov 12 '25 05:11 rickeylev

Summary of Changes

Hello @rickeylev, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is a work-in-progress effort to update the project's continuous integration (CI) to support and test with Bazel 8 on Windows. It involves a targeted overhaul of the CI configuration to focus on this specific environment, alongside comprehensive dependency updates across various MODULE.bazel and go.mod files to ensure full compatibility with the new Bazel version and its ecosystem.

Highlights

  • CI Configuration Update: The .bazelci/presubmit.yml has been significantly refactored to focus specifically on testing Windows with Bazel 8, utilizing a new matrix configuration for platforms and Bazel versions. This streamlines the CI to target the latest Bazel release on Windows.
  • Dependency Version Bumps: Several key dependencies have been updated across MODULE.bazel files, including rules_go (to 0.59.0), gazelle (to 0.47.0), and rules_java (to 8.16.1), ensuring compatibility with newer Bazel versions and related tooling.
  • Go Toolchain and Module Updates: The gazelle/go.mod file has been updated to Go 1.22.9 and includes a toolchain go1.23.6, along with updates to bazel-gazelle, buildtools, and doublestar/v4 dependencies and their corresponding checksums in go.sum.
  • Bzlmod Flag Stabilization: The .bazelrc file for gazelle/examples/bzlmod_build_file_generation has transitioned from using the experimental experimental_enable_bzlmod flag to the stable enable_bzlmod flag, indicating the maturity of Bazel's module system.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Nov 12 '25 05:11 gemini-code-assist[bot]

I think we merged a PR recently to fix the builds for BCR, do we still need this?

aignas avatar Dec 11 '25 02:12 aignas

I think we merged a PR recently to fix the builds for BCR, do we still need this?

#3404 removed Gazelle+Windows BCR testing, so I assume yes we still need it?

dougthor42 avatar Dec 11 '25 04:12 dougthor42

Ah, so this is for windows + bazel 8 testing for the gazelle plugin. SGTM then.

aignas avatar Dec 11 '25 05:12 aignas