bazelbuild
Cleanup proto rules and point to the source of truth
They have been moved to https://github.com/protocolbuffers/protobuf
Not sure who would be the best person to reach out about the status of wether the proto rules outside rules_python are useable already.
I think @alexeagle @comius were working on this? Last I remember, we were waiting for a protobuf release of something before we could switch rules_python to switch to loading them and mark them as deprecated.
I have not seen a migration plan for that. I don't think it's a wise plan to remove these from rules_python at this point. In fact much of the ecosystem has already moved off of the protobuf repo, now that the toolchain flag allows it.
I think I must be confused as to what is the ruleset that should be used for protobuf python library - is it not the py_proto_library from the protobuff repo that should be used instead of the py_proto_library in our repo? What is the maintained rule that people should be advised to use? I thought that it was definitely not py_proto_library from rules_python but not sure about the replacement.
I find it confusing as well. The recent changes are anonymous and have no context or indication of what they are doing:
I guess then it means that we'll just continue having the api as is and we leave the removal for 2.0.
On 3 September 2024 07:45:50 GMT+09:00, Alex Eagle @.***> wrote:
I find it confusing as well. The recent changes are anonymous and have no context or indication of what they are doing:
-- Reply to this email directly or view it on GitHub: https://github.com/bazelbuild/rules_python/issues/2173#issuecomment-2325356980 You are receiving this because you authored the thread.
Message ID: @.***>
This is the first I hear of a plan to deprecate py_proto_library in rules_python in favor of something in protobuf. Is there an issue or doc with more context?
@comius could you provide some clarity on what the plan is? If even the rules_python maintainers seem unsure, there's no hope for regular users like myself!
I wonder what is the functional difference between what we have and what is in https://github.com/protocolbuffers/protobuf/blob/cf688f339c80dc372a34302de6dae3d749ec8e72/bazel/py_proto_library.bzl#L132
Related slack discussion: https://bazelbuild.slack.com/archives/CKU1D04RM/p1732581509956829