rules_python icon indicating copy to clipboard operation
rules_python copied to clipboard

Update internal pip version to 23.3+

Open axbycc-mark opened this issue 1 year ago • 1 comments

🚀 feature request

Update internal pip version to 23.3+ The current internal pip version is specified as 23.2 https://github.com/bazelbuild/rules_python/blob/c5c03b2477dd1ce0c06c9dc60bf816995f222bcf/python/pip_install/repositories.bzl#L64

Relevant Rules

pip.parse compile_pip_requirements()

Description

The new http-v2 caching feature was introduced in pip 23.3. This feature separates out headers the body when caching responses from package servers. This fixes a performance issue that causes cached responses to be loaded and fully deserialized multiple times from disk during a single run of compile_pip_requirements / pip-compile. This is an issue for wheels that are GB in size.

Describe the solution you'd like

Update internal pip version to 23.3+ or maybe add a way for the user to specify the desired pip version when specifying pip.parse() or compile_pip_requirements().

Describe alternatives you've considered

Write a py_binary depending on the pip version I need and then run pip-compile inside that py_binary.

axbycc-mark avatar Mar 22 '24 22:03 axbycc-mark

I personally don't have time to look into this now, but will review PRs.

aignas avatar Mar 24 '24 07:03 aignas