rules_pkg icon indicating copy to clipboard operation
rules_pkg copied to clipboard

Many rpm tests are not running under bazel 7 (bzlmod)

Open aiuto opened this issue 10 months ago • 2 comments

Now that bazel 7 is the default for CI, and we are using bzlmod, the toolchain finder does not work. Worse than failing, they just silently skip, so it's as good as not having the tests.

//tests/rpm:analysis_tests_conflicting_inputs_base_case_passes_analysis SKIPPED
//tests/rpm:analysis_tests_conflicting_inputs_conflict_with_dir         SKIPPED
//tests/rpm:analysis_tests_conflicting_inputs_conflict_with_file        SKIPPED
//tests/rpm:analysis_tests_conflicting_inputs_conflict_with_symlink     SKIPPED
//tests/rpm:analysis_tests_naming_no_extra                              SKIPPED
//tests/rpm:analysis_tests_naming_with_different_name                   SKIPPED
//tests/rpm:pkg_rpm_basic_test                                          SKIPPED
//tests/rpm:pkg_rpm_smoke                                               SKIPPED
//tests/rpm:test_golden_sub_rpm_contents                                SKIPPED
//tests/rpm:test_rpm_dirs_contents_golden_test                          SKIPPED
//tests/rpm/source_date_epoch:source_date_epoch_from_file               SKIPPED
//tests/rpm/source_date_epoch:source_date_epoch_insource                SKIPPED
//tests/rpm/tree_artifacts:layer_with_files                             SKIPPED
//tests/rpm/tree_artifacts:layer_with_files_reversed                    SKIPPED
//tests/rpm/tree_artifacts:treeartifact_ops                             SKIPPED

aiuto avatar Apr 24 '24 03:04 aiuto

do you have a bit more context on where you're encountering this? I ran across this while pushing another PR and decided to check it out a bit, but I'm not encountering this when I'm running locally nor in my latest PR.

kellyma2 avatar Apr 25 '24 04:04 kellyma2

I think the bzlmod extension that finds the toolchain is just wrong. I implemented it in a hurry and may have just missed.

aiuto avatar Apr 25 '24 19:04 aiuto