rules_pkg pkg_install should support symbolic links, treeartifacts

These weren't implemented in #380, and might be needed in some cases.

Jul 30 '21 17:07 nacl

Hi, any updates to this? I see that the code is there, just disabled by a NotImplementedError: https://github.com/bazelbuild/rules_pkg/blob/447fb8e246cb437630b9ecd09f9bf9fe857d2c3f/pkg/private/install.py.tpl#L106

Context: We are trying to use pkg_install to replace our custom target with similar functionalities: https://cs.android.com/android/kernel/superproject/+/common-android-mainline:build/bazel_common_rules/dist/dist.bzl.

Aug 16 '24 03:08 jacky8hyf

I think it was left unimplemented because there are no tests for it. If you want to send a PR to add a test and enable it, that would be great.

Aug 16 '24 04:08 aiuto

For clarity, I originally left this unimplemented because the initial use case didn't need this functionality. It shouldn't be too hard to implement it, though.

Aug 16 '24 13:08 nacl

#885 added support for tree artifacts. I'm not sure why github didn't cross link that. There still seems to be a little more work for symlinks, so I'm not closing this.

Sep 04 '24 03:09 aiuto