rules_pkg icon indicating copy to clipboard operation
rules_pkg copied to clipboard

package mapping rule "attributes" should be more strongly defined

Open nacl opened this issue 4 years ago • 2 comments

The current pkg_attributes macro has undefined behavior: each argument defaults to None and as is left open to interpretation by the package builder. This can leave some things dependent on the environment, losing hermiticity. Most important ones are likely user and the group

Some non-mutually-exclusive options:

  • Leave it as-is.
  • Set defaults in pkg_attributes
  • Allow for overriding default attributes in pkg_filegroup
  • Codify the behavior in the packaging rules level

nacl avatar Jun 28 '21 19:06 nacl

And another

  • add fallback value attributes to the package building rules

I'm not sure I know enough yet to pick the right solution. I do know that what I would like is for a *_binary to show up as executable and for data files to be 0x444 - without the user having to say anything.

aiuto avatar Jun 29 '21 04:06 aiuto

Also, we might consider using symbolic names for modes. Instead of the posix octal modes, perhaps go to the chmod model ( ugo+-rwx ). The reason to do that now is so that when we add a windows installer, we can translate desired modes to the Windows equivalent.

aiuto avatar Jul 08 '21 20:07 aiuto