rules_nodejs icon indicating copy to clipboard operation
rules_nodejs copied to clipboard

fix(builtin): ensure bazel config directories are expanded to prevent escapes

Open joeljeske opened this issue 3 years ago • 0 comments

… escapes

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [X] Bugfix
  • [ ] Feature (please, look at the "Scope of the project" section in the README.md file)
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

What is the current behavior?

The runtime symlink patches on FS are not currently catching node_module roots in the bazel gendirs in bazel-out. There appears to have been an attempt to catch these roots but a faulty shell expansion was preventing these roots from being guarded.

Issue Number: N/A

What is the new behavior?

Symlinks are guarded properly from escaping from the desired module roots

Does this PR introduce a breaking change?

  • [ ] Yes
  • [X] No

Other information

joeljeske avatar Sep 14 '22 17:09 joeljeske