rules_nodejs icon indicating copy to clipboard operation
rules_nodejs copied to clipboard

feat(concatjs): allows the usage of @bazel/concatjs rules without Karma

Open realtimetodie opened this issue 2 years ago • 1 comments

Seperates the @bazel/concatjs rules from the Karma web testing rules, by moving the karma_web_test rule and karma_web_test_suite rule into a dedicated subdirectory in packages/concatjs/web_test.

As a user, I want to use the @bazel/concatjs devserver rules without the requirement to install the io_bazel_rules_webtesting dependency. This dependency is only required by Karma web testing rules.

Before

load("@npm//@bazel/concatjs:index.bzl", "karma_web_test_suite")

After

load("@npm//@bazel/concatjs/web_test:index.bzl", "karma_web_test_suite")

The documentation was updated accordingly. The Karma web testing documentation in docs/Karma.md was updated. Previously, the documentation mentioned the @bazel/karma package.

realtimetodie avatar Apr 16 '22 08:04 realtimetodie

It sounds good to reduce the accidental coupling here. However it's a breaking change to the public API so it has to wait for the next major release, following semver.

alexeagle avatar Apr 16 '22 20:04 alexeagle