rules_nodejs icon indicating copy to clipboard operation
rules_nodejs copied to clipboard

npm_package_bin doesn't pass through `tags`

Open arohner opened this issue 2 years ago • 2 comments

🚀 feature request

npm_package_bin doesn't seem to pass through tags=["no-sandbox"] to the underlying actions. It would be great if it did.

Relevant Rules

npm_package_bin

Description

I have an npm_package_bin action that works with --spawn_strategy=local, but fails under the sandbox. As a quick hack, it would be nice if I could disable the sandbox on this particular step without disabling it for the rest of the build.

arohner avatar Dec 20 '21 15:12 arohner

you should just turn on experimental_allow_tags_propagation in your bazelrc https://github.com/bazelbuild/bazel/issues/8830

which fixes it for npm_package_bin and also every other custom Bazel rule.

alexeagle avatar Dec 20 '21 19:12 alexeagle

This issue has been automatically marked as stale because it has not had any activity for 6 months. It will be closed if no further activity occurs in 30 days. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

github-actions[bot] avatar Jul 19 '22 03:07 github-actions[bot]

This issue was automatically closed because it went 30 days without any activity since it was labeled "Can Close?"

github-actions[bot] avatar Aug 19 '22 03:08 github-actions[bot]