Flag --incompatible_disable_target_provider_fields will break rules_nodejs in Bazel 1.2.1

[bazel-flag-bot]

Incompatible flag --incompatible_disable_target_provider_fields will break rules_nodejs once Bazel 1.2.1 is released.

Please see the following CI builds for more information:

• [:ubuntu: 18.04 (OpenJDK 11)](:ubuntu: 18.04 (OpenJDK 11))
• [RBE (:ubuntu: 16.04, OpenJDK 8)](RBE (:ubuntu: 16.04, OpenJDK 8))
• [:ubuntu: 18.04 (OpenJDK 11)](:ubuntu: 18.04 (OpenJDK 11))
• [:windows: (OpenJDK 8)](:windows: (OpenJDK 8))
• [:ubuntu: 18.04 (OpenJDK 11)](:ubuntu: 18.04 (OpenJDK 11))
• [:ubuntu: 18.04 (OpenJDK 11)](:ubuntu: 18.04 (OpenJDK 11))
• [:ubuntu: 16.04 (OpenJDK 8)](:ubuntu: 16.04 (OpenJDK 8))
• [:darwin: (OpenJDK 8)](:darwin: (OpenJDK 8))
• [:ubuntu: 16.04 (OpenJDK 8)](:ubuntu: 16.04 (OpenJDK 8))
• [:windows: (OpenJDK 8)](:windows: (OpenJDK 8))
• [:ubuntu: 18.04 (OpenJDK 11)](:ubuntu: 18.04 (OpenJDK 11))
• [:darwin: (OpenJDK 8)](:darwin: (OpenJDK 8))
• [:windows: (OpenJDK 8)](:windows: (OpenJDK 8))
• [:ubuntu: 16.04 (OpenJDK 8)](:ubuntu: 16.04 (OpenJDK 8))
• [:darwin: (OpenJDK 8)](:darwin: (OpenJDK 8))
• [:darwin: (OpenJDK 8)](:darwin: (OpenJDK 8))
• [:darwin: (OpenJDK 8)](:darwin: (OpenJDK 8))
• [:ubuntu: 18.04 (OpenJDK 11)](:ubuntu: 18.04 (OpenJDK 11))
• [:windows: (OpenJDK 8)](:windows: (OpenJDK 8))

Questions? Please file an issue in https://github.com/bazelbuild/continuous-integration

Important: Please do NOT modify the issue title since that might break our tools.

[shahms]

This appears to still be broken in 1.0.0: $ bazel test --incompatible_disable_target_provider_fields //kythe/... INFO: Invocation ID: e975bcba-8ad5-4d00-bdbb-6f88fad2b7a4 WARNING: /usr/local/google/home/shahms/src/kythe/kythe/go/platform/tools/viewindex/BUILD:5:1: target '//kythe/go/platform/tools/viewindex:viewindex' is deprecated: Please use kzip view instead WARNING: /usr/local/google/home/shahms/src/kythe/kythe/go/platform/kindex/BUILD:5:1: target '//kythe/go/platform/kindex:kindex' is deprecated: Please use //kythe/go/platform/kzip WARNING: /usr/local/google/home/shahms/.cache/bazel/_bazel_shahms/f0c8a49cbf1bfaa82de86be744427f4b/external/remote_java_tools_linux/BUILD:671:1: in hdrs attribute of cc_library rule @remote_java_tools_linux//:combiners: Artifact 'external/remote_java_tools_linux/java_tools/src/tools/singlejar/zip_headers.h' is duplicated (through '@remote_java_tools_linux//:transient_bytes' and '@remote_java_tools_linux//:zip_headers'). Since this rule was created by the macro 'cc_library', the error might have been caused by the macro implementation ERROR: /usr/local/google/home/shahms/.cache/bazel/_bazel_shahms/f0c8a49cbf1bfaa82de86be744427f4b/external/npm/@protobufjs/codegen/BUILD.bazel:56:1: in @build_bazel_rules_nodejs//internal/common:module_mappings.bzl%module_mappings_runtime_aspect aspect on filegroup rule @npm//@protobufjs/codegen:codegen__all_files: Traceback (most recent call last): File "/usr/local/google/home/shahms/.cache/bazel/_bazel_shahms/f0c8a49cbf1bfaa82de86be744427f4b/external/npm/@protobufjs/codegen/BUILD.bazel", line 56 @build_bazel_rules_nodejs//internal/common:module_mappings.bzl%module_mappings_runtime_aspect(...) File "/usr/local/google/home/shahms/.cache/bazel/_bazel_shahms/f0c8a49cbf1bfaa82de86be744427f4b/external/build_bazel_rules_nodejs/internal/common/module_mappings.bzl", line 141, in _module_mappings_runtime_aspect_impl get_module_mappings(<4 more arguments>) File "/usr/local/google/home/shahms/.cache/bazel/_bazel_shahms/f0c8a49cbf1bfaa82de86be744427f4b/external/build_bazel_rules_nodejs/internal/common/module_mappings.bzl", line 68, in get_module_mappings getattr(dep, mappings_attr) Accessing providers via the field syntax on structs is deprecated and will be removed soon. It may be temporarily re-enabled by setting --incompatible_disable_target_provider_fields=false. See https://github.com/bazelbuild/bazel/issues/9014 for details.

[cgruber]

Please reopen this - it is still occurring in 1.1.0

ERROR: /Users/gruber/Projects/github.com/cgruber/rules_kotlin/examples/node/coroutines-helloworld/BUILD:17:1: in @build_bazel_rules_nodejs//internal/common:module_mappings.bzl%module_mappings_runtime_aspect aspect on kt_js_library rule //coroutines-helloworld:app: 
Traceback (most recent call last):
	File "/Users/gruber/Projects/github.com/cgruber/rules_kotlin/examples/node/coroutines-helloworld/BUILD", line 17
		@build_bazel_rules_nodejs//internal/common:module_mappings.bzl%module_mappings_runtime_aspect(...)
	File "/private/var/tmp/_bazel_gruber/d5a019456767b7d57e78368f8fc4d983/external/build_bazel_rules_nodejs/internal/common/module_mappings.bzl", line 141, in _module_mappings_runtime_aspect_impl
		get_module_mappings(<4 more arguments>)
	File "/private/var/tmp/_bazel_gruber/d5a019456767b7d57e78368f8fc4d983/external/build_bazel_rules_nodejs/internal/common/module_mappings.bzl", line 68, in get_module_mappings
		getattr(dep, mappings_attr)
Accessing providers via the field syntax on structs is deprecated and will be removed soon. It may be temporarily re-enabled by setting --incompatible_disable_target_provider_fields=false. See https://github.com/bazelbuild/bazel/issues/9014 for details.

[cgruber]

@alexeagle - why was this closed?

[Whoaa512]

This is still an issue, please re-open

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had any activity for 6 months. It will be closed if no further activity occurs in 30 days. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

[github-actions[bot]]

This issue was automatically closed because it went 30 days without any activity since it was labeled "Can Close?"