rules_license icon indicating copy to clipboard operation
rules_license copied to clipboard

Expand list of attributes inspected when collecting license information

Open davidkurkov opened this issue 2 years ago • 3 comments

Expected Behavior

LicensesInfo / LicenseInfo will be collected by reviewing all attributes of objects passed in to the gather_licenses_info aspect.

Actual Behavior

The list of attributes that are inspected for LicenseInfo / LicensesInfo does not gather licenses for all third party libraries included in an android app binary.

Steps to Reproduce the Problem

  1. Use gather_licenses_info aspect to collect license information for your deps

Note: the same way as shown in this docstring

Specifications

  • We found including exports allows us to find significantly more licenses when building an android binary.

  • Version: 0.0.3

  • Platform: Android

davidkurkov avatar Oct 18 '22 19:10 davidkurkov

I'm sure there are more attributes that would be helpful to inspect as well. But conversely, there are likely attributes from which we would not want to collect license information for depending on the goal - i.e., if we wanted to only find licenses for libraries that are compiled into an app binary we wouldn't want to include attributes like exports_plugins.

davidkurkov avatar Oct 18 '22 19:10 davidkurkov

Much of this might be addressed in a code drop this week. Stay tuned.

aiuto avatar Oct 24 '22 17:10 aiuto

FYI: https://github.com/bazelbuild/rules_license/pull/53

aiuto avatar Nov 01 '22 16:11 aiuto