rules_kotlin icon indicating copy to clipboard operation
rules_kotlin copied to clipboard

'kt_abi_plugin_incompatible' should be respected even if 'experimental_use_abi_jars' is False

Open oliviernotteghem opened this issue 2 years ago • 1 comments

In kotlin/internal/jvm/compile.bzl :

  •    if not "kt_abi_plugin_incompatible" in ctx.attr.tags and toolchains.kt.experimental_use_abi_jars == True:
    

We should probably do a larger cleanup, and remove all ref to experimental_use_abi_jars toolchain attribute

oliviernotteghem avatar May 04 '22 20:05 oliviernotteghem

experimental_use_abi_jars should remain false til 1.7 release. This is due to 1.6.20 being the first version that abi generation is 99% correct.

restingbull avatar May 06 '22 19:05 restingbull