rules_kotlin icon indicating copy to clipboard operation
rules_kotlin copied to clipboard

maintenance: Remove dagger from the builder

Open agluszak opened this issue 3 months ago • 3 comments

agluszak avatar Dec 10 '25 14:12 agluszak

Why?

restingbull avatar Dec 10 '25 22:12 restingbull

Let my reverse the question: why is it there in the first place? It doesn't seem to make anything simpler/easier, only adds boilerplate. I thought maybe it served some purpose in the past and now it's legacy? We removed it in our internal fork

agluszak avatar Dec 10 '25 23:12 agluszak

I mean, my main argument is simplicity and a negative diff after removing it, but if you like dagger because of code style preferences - I don't want to start a tabs vs spaces holy war :)

agluszak avatar Dec 10 '25 23:12 agluszak

Not against dropping Dagger from the rules builder impl. since it just adds overhead to the rules, we should make sure that these Dagger specific code paths/integrations are being exercised elsewhere in tests so that we don't accidentally cause regressions in the future.

Bencodes avatar Dec 12 '25 22:12 Bencodes