rules_k8s icon indicating copy to clipboard operation
rules_k8s copied to clipboard

Upstream Change: github.com/bazelbuild/rules_docker/container/go/pkg/compat

Open moriarty opened this issue 4 years ago • 4 comments

This line will fail: https://github.com/bazelbuild/rules_k8s/blob/ab522ec5bc096612630c2b85c8c23be87e84ecde/k8s/go/pkg/resolver/resolver.go#L231

with this incoming upstream change: https://github.com/bazelbuild/rules_docker/pull/1934

https://github.com/bazelbuild/rules_docker/blob/debc18a646204743ca8e3b4d66341c762e5f3896/container/go/pkg/compat/reader.go#L299-L300

moriarty avatar Oct 12 '21 21:10 moriarty

PR #669 fixes this

moriarty avatar Oct 12 '21 23:10 moriarty

As it took me a while to find; using rules_k8s 0.6 w. rules_docker 0.20.0 is broken due to cross-imports, returning the error:

% bazel build //some/thing:kubernetes
... 
Use --sandbox_debug to see verbose messages from the sandbox
external/io_bazel_rules_k8s/k8s/go/cmd/resolver/resolver.go:163:14: undefined: compat.ReadImage
compilepkg: error running subcommand external/go_sdk/pkg/tool/linux_amd64/compile: exit status 2
Target //... failed to build
Use --verbose_failures to see the command lines of failed build steps.

I got rules_k8s working by downgrading rules_docker to 0.19.0 (see https://github.com/bazelbuild/rules_docker/releases/tag/v0.19.0)

msiebuhr avatar Nov 18 '21 12:11 msiebuhr

I believe I'm encountering this error atm:

ERROR: /home/sam.ainsworth/.cache/bazel/_bazel_sam.ainsworth/775ff40785267b278505e7d465553528/external/io_bazel_rules_k8s/k8s/go/pkg/resolver/BUILD.bazel:3:11: GoCompilePkg external/io_bazel_rules_k8s/k8s/go/pkg/resolver/resolver.a [for host] failed: (Exit 1): builder failed: error executing command bazel-out/host/bin/external/go_sdk/builder compilepkg -sdk external/go_sdk -installsuffix linux_amd64 -src external/io_bazel_rules_k8s/k8s/go/pkg/resolver/resolver.go -embedroot '' -embedroot ... (remaining 29 arguments skipped)
Remote action 0184caabb5570dd7fd2227380b3ea09bd00406051f2c625cec94aba75698fb7b/374 failed with action exit code 1 and gRPC status 0
external/io_bazel_rules_k8s/k8s/go/pkg/resolver/resolver.go:258:15: undefined: compat.Reader
compilepkg: error running subcommand external/go_sdk/pkg/tool/linux_amd64/compile: exit status 2

even though I'm on rules_k8s 0.7 and rules_docker 0.14.1... how could this still be occurring even after the PR has been merged?

samuela avatar Feb 14 '23 19:02 samuela

Downgrading to rules_k8s 0.6 solved the issue for me. (Unfortunately that was easier than upgrading rules_docker.)

samuela avatar Feb 15 '23 02:02 samuela